-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elemental issue templeate #356
Conversation
80ba215
to
e2958e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of nits, looks good here!
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
|
||
**Environment:** | ||
|
||
- Elemental version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we expect the user will report here? The version of the elemental operator (the helm chart we release), right?
Looks good for this PR, probably we may want in the near future (another PR) to review the README of the repo and to update the RELEASES page --> created issue #363
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we expect the user will report here? The version of the elemental operator (the helm chart we release), right?
I think in this repo more the Elemental
version itself (ISO/iPXE), otherwise the draft should be in elemental-operator
, no? Or also the version of the CLI and the toolkit might be needed (toolkit less interesting in fact maybe)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, makes sense, the ISO is likely the only thing that we should address here.
What confused me a bit is that while previously there was no operator and the cluster installation logic was managed by the binaries inside the ISO (so basically the ISO was Elemental, a 1:1 match), now there is the operator that takes care of the cluster provisioning part and that manages the configuration for the Elemental installation. So in my mind an "Elemental" release is made up of both the ISO and the operator chart.
Anyway, guess all will be more clear as soon as we update the Release section .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should tell users to put here output from cat /etc/os-release
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the content of /etc/os-release
, it should have we need, at least to know the image used.
I know that @Itxaka also begin to code an elemental-support
tool that was/is mainly for dev purposes, but maybe it could be a good idea to add the resulting file in an issue? Let's see this for a later evolution of the draft, as I don't know if this tool will still exists.
7b5c259
to
471fd9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #312 Signed-off-by: Michal Jura <[email protected]>
471fd9b
to
c56f0be
Compare
Fixes #312
Signed-off-by: Michal Jura [email protected]